On Hold notices are being sent when previous hold expires

Notes

We've just discovered a massive bug with the way on hold / available for pickup notices are being sent in Chicago production.

These notices are supposed to be triggered in real time when an item is returned. This is the ONLY time they are supposed to be sent. Suddenly these notices are being sent when an item was on hold for a previous patron and that hold expires.

In other words, Item X is on hold for Patron 1 and has a second request in the queue for Patron 2. The hold expires. Patron 2 receives an email notice that the item is available for pickup.

This should NEVER happen. The notice should only be sent once the item is checked in after the hold expires. This causes massive confusion for the following reasons:
1. The pickup location may be different for the second request, in which case the item will not be physically available for pickup.
2. The item will not have a hold slip printed for Patron 2, so may not be found by staff.
3. There is no on hold expiration date (because the item has not been checked in), so the notice displays no hold expiration date.

This needs to be fixed as soon as possible!

I will attach examples of the notices sent.

Assignee

Holly Mistlebauer

Reporter

David Bottorff

Labels

None

Priority By Function

1 - Deliver

Solr Version

None

Work Group

None

Process & Sub-Process

Deliver - Request

Parent Jira

None

Co-Assignee/s

None

Due By

None

Contribution

No

Contributing Developer

None

Contributing Institution

None

Contribution Type

None

Value Proposition

None

Components

Fix versions

Priority

Critical
Configure